Activity

From 12/29/2010 to 01/27/2011

01/02/2011

avatar 01:22 AM Bug #43: amcc.rb issues
I don't really seem much point in special handling of whitespace in `adapter_num`. We might just as well support any other weird data types or special values. Why exactly do you want to handle space (or whitespace / empty strings) the same way ... Mikhail Yakshin

12/30/2010

avatar 06:18 PM Bug #43: amcc.rb issues
Hey, If adapter_num is passed in as a space then the script blows up. It executes: /var/lib/einarc/tools/amcc/cli /c show which is wrong. If the adapter_num is an empty space it should execute: /var/lib/einarc/tools/amcc/cli /c0 show ... Justin Mazzi
avatar 03:57 AM Bug #43: amcc.rb issues
Justin Mazzi wrote: > That fix will work unless adapter_num contains a space - https://gist.github.com/cbecad65fe07cafb1f0d This one doesn't work for me as you say. I've checked both Ruby 1.8 and 1.9 - @' '.empty?@ is false all the time, thus ... Mikhail Yakshin

12/29/2010

avatar 10:36 PM Bug #43: amcc.rb issues
Hey, That fix will work unless adapter_num contains a space - https://gist.github.com/cbecad65fe07cafb1f0d Justin Mazzi
avatar 07:18 PM Bug #43 (Resolved): amcc.rb issues
I've applied a fix in r1861, to enforce a similar model of default value for @adapter_num@. Please check it out and see if it works for you? Mikhail Yakshin
avatar 06:48 PM Bug #43 (Assigned): amcc.rb issues
Thanks for your contribution! I'll try to estimate what's best overall and apply a relevant patch ASAP. Mikhail Yakshin
avatar 04:04 PM Bug #43: amcc.rb issues
Our developer made things "pretty" so you can see the code changes better: https://gist.github.com/e0e43e59a48cea506cc7 Jeremy Miller
« Previous
Next »
 

Also available in: Atom